Skip to content

Add more formula tests for min and max functions #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2023
Merged

Add more formula tests for min and max functions #623

merged 3 commits into from
Sep 12, 2023

Conversation

@matthias-wende-frequenz
Copy link
Contributor

@matthias-wende-frequenz matthias-wende-frequenz commented Aug 30, 2023 •
edited
Loading

Also we make the interface public as it's considered ready to use.

@matthias-wende-frequenz matthias-wende-frequenz requested a review from a team as a code owner August 30, 2023 15:32
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:data-pipeline Affects the data pipeline labels Aug 30, 2023
@github-actions github-actions bot added the part:docs Affects the documentation label Aug 30, 2023
@matthias-wende-frequenz matthias-wende-frequenz added this to the v1.0.0-rc milestone Aug 30, 2023
@shsms
Copy link
Contributor

shsms commented Sep 5, 2023

In the tests, could you add additional inputs that test both sides of max/min for each case? Looks like all cases are just testing just one side.

It would be nice to have some -, / as well, because those are the trickier parts of formulas.

Also it would be nice to test cases that have basic operations inside and to the right of min/max. Like: a - b.min(c / d) - (c - e), etc.

shsms
shsms previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@shsms shsms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests to make sure that this works in strange cases and I'm now convinced that this works. So I have no objections to taking this in as it is now.

daniel-zullo-frequenz
daniel-zullo-frequenz reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@daniel-zullo-frequenz daniel-zullo-frequenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a question/comment to check for and LGTM

@matthias-wende-frequenz matthias-wende-frequenz added this pull request to the merge queue Sep 12, 2023
Merged via the queue into frequenz-floss:v0.x.x with commit c32d84c Sep 12, 2023
@matthias-wende-frequenz matthias-wende-frequenz deleted the minmax_tests branch September 12, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-zullo-frequenz daniel-zullo-frequenz daniel-zullo-frequenz approved these changes

@shsms shsms shsms left review comments

Assignees

@matthias-wende-frequenz matthias-wende-frequenz

Labels

part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:tests Affects the unit, integration and performance (benchmarks) tests

Projects

Python SDK Roadmap
Status: Done

Milestone

v1.0.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@matthias-wende-frequenz @shsms @daniel-zullo-frequenz @cwasicki